rot1 #2

Merged
gbrochar merged 13 commits from rot1 into master 2024-08-20 13:52:23 +00:00
Collaborator

je sais pas ce que je fais

je sais pas ce que je fais
pbonilla added 3 commits 2024-05-23 11:54:06 +00:00
2c14d6f0c5 infection of PT_LOAD
reference to text section removed
multiple infections OK
gbrochar requested review from gbrochar 2024-05-23 11:54:31 +00:00
gbrochar requested changes 2024-05-23 11:56:42 +00:00
gbrochar left a comment
Owner

J'ai pas lu le code utile mais t'as laisse des printfs

J'ai pas lu le code utile mais t'as laisse des printfs
srcs/encrypt.c Outdated
@ -8,4 +8,8 @@ void encrypt(char *file, unsigned long int offset, unsigned long int size)
file[offset + i] = file[offset + i] - 1;
++i;
}
printf("\nENCRYPTION : \n");
Owner

use ft_printf (4 lines)

use ft_printf (4 lines)
gbrochar marked this conversation as resolved
srcs/main.c Outdated
@ -9,3 +9,3 @@
if (fd < 0)
{
ft_printf("Error: Failed to open \'%s\'\n", woody->file_path);
printf("Error: Failed to open \'%s\'\n", woody->file_path);
Owner

use ft_printf

use ft_printf
gbrochar marked this conversation as resolved
srcs/main.c Outdated
@ -16,3 +16,3 @@
{
close(fd);
ft_printf("Error: Failed to read file offset \'%s\'\n", woody->file_path);
printf("Error: Failed to read file offset \'%s\'\n", woody->file_path);
Owner

use ft_printf

use ft_printf
gbrochar marked this conversation as resolved
srcs/main.c Outdated
@ -24,3 +24,3 @@
{
close(fd);
ft_printf("Error: Failed to map file \'%s\'\n", woody->file_path);
printf("Error: Failed to map file \'%s\'\n", woody->file_path);
Owner

use ft_printf

use ft_printf
gbrochar marked this conversation as resolved
srcs/woody.c Outdated
@ -10,3 +10,3 @@
int fd = open(path, O_CREAT | O_WRONLY | O_TRUNC, 0755);
if (fd == -1) {
ft_printf("Error: Failed to create new file \'%s\'\n", path);
printf("Error: Failed to create new file \'%s\'\n", path);
Owner

use ft_printf

use ft_printf
gbrochar marked this conversation as resolved
srcs/woody.c Outdated
@ -16,3 +16,3 @@
if (write(fd, file, size) == -1) {
close(fd);
ft_printf("Error: Failed to write new file \'%s\'\n", path);
printf("Error: Failed to write new file \'%s\'\n", path);
Owner

use ft_printf

use ft_printf
gbrochar marked this conversation as resolved
srcs/woody.c Outdated
@ -21,3 +21,3 @@
if (close(fd) == -1) {
ft_printf("Error: Failed to close new file \'%s\'\n", path);
printf("Error: Failed to close new file \'%s\'\n", path);
Owner

use ft_printf

use ft_printf
gbrochar marked this conversation as resolved
srcs/woody.c Outdated
@ -177,3 +160,3 @@
if (!woody->Ehdr || !elf_magic_numbers(woody->file) || woody->Ehdr->e_ident[EI_CLASS] != ELFCLASS64)
{
ft_printf("Error: \'%s\' is not a valid 64-bit ELF file\n", woody->file_path);
printf("Error: \'%s\' is not a valid 64-bit ELF file\n", woody->file_path);
Owner

use ft_printf

use ft_printf
gbrochar marked this conversation as resolved
pbonilla scheduled this pull request to auto merge when all checks succeed 2024-05-23 12:05:20 +00:00
pbonilla added 4 commits 2024-06-12 11:41:34 +00:00
pbonilla added 1 commit 2024-06-16 14:37:15 +00:00
pbonilla added 1 commit 2024-06-17 17:29:02 +00:00
pbonilla added 1 commit 2024-06-18 16:11:30 +00:00
pbonilla added 2 commits 2024-06-21 17:20:47 +00:00
pbonilla added 1 commit 2024-07-24 14:59:36 +00:00
Owner

Bon je merge car il y a trop de commits, je sais pas si ca fonctionne, je vais aussi merge mon commit sans que tu le review et essayer de pauffinner un peu tout ca d'ici a vendredi.

On pourra rediscuter du workflow git pour famine, surtout si le projet est simple ca permettra de faire un truc propre. Si t'es OP bien sur.

Bon je merge car il y a trop de commits, je sais pas si ca fonctionne, je vais aussi merge mon commit sans que tu le review et essayer de pauffinner un peu tout ca d'ici a vendredi. On pourra rediscuter du workflow git pour famine, surtout si le projet est simple ca permettra de faire un truc propre. Si t'es OP bien sur.
gbrochar requested review from gbrochar 2024-08-20 13:51:46 +00:00
gbrochar approved these changes 2024-08-20 13:51:53 +00:00
gbrochar merged commit 270479ced3 into master 2024-08-20 13:52:23 +00:00
Sign in to join this conversation.
No reviewers
No Label
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gbrochar/woody-woodpacker#2
No description provided.