From d84000d381d3bf453f22bc9eaa138de04634d335 Mon Sep 17 00:00:00 2001
From: Sinux <wshmelo@gmail.com>
Date: Thu, 29 Jan 2015 18:50:42 +0800
Subject: [PATCH] Update models.py

Wonder if it is better to  return a local variable  inside a while-loop?
---
 app/models.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/app/models.py b/app/models.py
index 73de129..9dda1a3 100644
--- a/app/models.py
+++ b/app/models.py
@@ -46,9 +46,8 @@ class User(db.Model):
         while True:
             new_nickname = nickname + str(version)
             if User.query.filter_by(nickname=new_nickname).first() is None:
-                break
+                return new_nickname
             version += 1
-        return new_nickname
 
     def is_authenticated(self):
         return True